Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add azure: build_id to schema #1871

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Add azure: build_id to schema #1871

merged 7 commits into from
Mar 20, 2024

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Mar 20, 2024 •
edited
Loading

Checklist

  • Added a news entry

@isuruf isuruf requested a review from a team as a code owner March 20, 2024 14:21
@isuruf isuruf mentioned this pull request Mar 20, 2024
Closed
1 task
@jaimergp
Copy link
Member

Nice! Should we also restore azure.user_or_org pre-schema behavior?

beckermr
beckermr reviewed Mar 20, 2024
View reviewed changes
@isuruf
Copy link
Member Author

isuruf commented Mar 20, 2024

Nice! Should we also restore azure.user_or_org pre-schema behavior?

It's already there.

@isuruf
Copy link
Member Author

isuruf commented Mar 20, 2024

pre-commit.ci autofix

@jdblischak
Copy link
Member

It's already there.

Nice. I confirmed locally that azure.user_or_org this works to update the URLs in the README.

But the description is confusing. It says GitHub when it should say Azure

conda-smithy/conda_smithy/data/conda-forge.json

Line 136 in 44acb93

"description": "The name of the GitHub user or organization, if passed with the GithubConfig provider, must comply with the value of the user_or_org field",

jdblischak
jdblischak approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built this branch locally and confirmed that the edits I made to azure.build_id, azure.user_or_org, and azure.project_name were reflected in the README Azure URLs. Thanks @isuruf!

@isuruf isuruf requested a review from beckermr March 20, 2024 16:28
@isuruf isuruf merged commit 0f54614 into conda-forge:main Mar 20, 2024
2 checks passed
@isuruf isuruf deleted the schema_build_id branch March 20, 2024 16:57
@jdblischak jdblischak mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdblischak jdblischak jdblischak approved these changes

@jaimergp jaimergp jaimergp approved these changes

@beckermr beckermr Awaiting requested review from beckermr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isuruf @jaimergp @jdblischak @beckermr